When did your dog finally "get" loose leash walking

Been working on loose leash for what feels like forever. some days are better than others but we still have so many walks where he pulls the whole time.

Starting to wonder if im doing something wrong or if this just takes longer than i thought. how long did it take for your dogs?